Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aachen turbine test case #2293

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Fix Aachen turbine test case #2293

merged 5 commits into from
Jun 27, 2024

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented May 29, 2024

Proposed Changes

This PR is for fixing #2276.

With the observations in #2276 and after discussion with @joshkellyjak, the fix proposed in #2246 is probably the correct one.

Related Work

#2158, #2246, #2260

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh linked an issue May 29, 2024 that may be closed by this pull request
Aachen Turbine Test Case #2276
Closed
bigfooted
bigfooted approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@bigfooted bigfooted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshkellyjak
Copy link
Contributor

Uploading these here for future reference. The fix for the address sanitiser results in a slight change in the values calculated at the shroud during the averaging process in the mixing plane when using linear interpolation.

TotPress_Outflow_1
VelNorm_Inflow_1

Base is without fix, modified is with fix.

@jblueh jblueh changed the title [WIP] Fix Aachen turbine test case Fix Aachen turbine test case Jun 27, 2024
@jblueh jblueh merged commit 30db707 into develop Jun 27, 2024
35 checks passed
@jblueh jblueh deleted the fix_aachen_turbine branch June 27, 2024 17:51
@jblueh jblueh mentioned this pull request Jun 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcarruscag pcarruscag pcarruscag approved these changes

@bigfooted bigfooted bigfooted approved these changes

Assignees
No one assigned
Labels
changelog:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aachen Turbine Test Case
4 participants
@jblueh @joshkellyjak @bigfooted @pcarruscag